Fix detecting terminal under Git Bash on Windows#119
Merged
Conversation
vilmibm
approved these changes
Nov 27, 2019
mislav
pushed a commit
that referenced
this pull request
Sep 28, 2021
ghcs: don't double-print errors
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
cchristous
pushed a commit
to cchristous/cli
that referenced
this pull request
Feb 28, 2026
workflow stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git Bash is, to me, a very useful terminal emulator that comes with Git for Windows.
It looks like
IsTerminal()fromgolang.org/x/crypto/ssh/terminalreturns a false negative for Git Bash. I have switched toIsCygwinTerminal()fromgithub.com/mattn/go-isattyand querytput colsto get terminal width.