Add dynamic user switching based on git config gh.user (POC for #326)#11388
Draft
Add dynamic user switching based on git config gh.user (POC for #326)#11388
Conversation
This feature allows the GitHub CLI to automatically switch users based on a repository-specific git config setting 'gh.user'. This enables seamless work with multiple GitHub accounts across different repositories. Features: - Reads gh.user from git config when in a repository - Automatically switches to the configured user before authentication - Graceful error handling with warnings for invalid users - Non-breaking: commands continue to work if user switching fails - Works with all authenticated commands (pr, repo, auth, etc.) Usage: git config gh.user <username> # Set user for current repository gh pr create # Uses the configured user automatically 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added proper unit tests for the git config based user switching functionality: Test Coverage: - ✅ Not in git repository (graceful skip) - ✅ Git repository errors (graceful skip) - ✅ No gh.user configured (graceful skip) - ✅ No authenticated hosts (graceful skip) - ✅ No active user (graceful skip) - ✅ User already matches current (no switch needed) - ✅ Configured user not authenticated (proper error) - ✅ Successful user switch (core functionality) - ✅ User switch fails (error handling) Implementation improvements: - Extracted GitClientInterface for better testability - Added internal maybeAutomaticUserSwitchWithGitClient for dependency injection - Comprehensive mocks for gh.Config, gh.AuthConfig, and git client - Tests verify both success and failure scenarios - Tests check that SwitchUser is called with correct parameters All tests pass: 9/9 scenarios covered 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proof of concept implementation for #326. Adds automatic user switching based on repository-specific
gh.usergit config setting.Implementation
When any authenticated command runs, the CLI automatically:
gh.userfrom git configUsage
As described in #326, configure per-repository users using git config include:
Now all gh commands automatically use the appropriate user based on repository location:
Files Changed
internal/config/git_user_switch.go- Core switching logicpkg/cmd/factory/default.go- Integration point in HTTP client factoryinternal/config/git_user_switch_test.go- Test suite (9 scenarios)Testing
All test scenarios pass:
Proof of Concept Status
This is a functional POC demonstrating the core concept. Implementation works as described in #326 but may need refinement for production:
gh auth switchUXManual Verification
Tested with two authenticated users. Switching works correctly:
Invalid users show warning but don't break commands.
Note: This POC was generated with Claude Code as a vibecoded exploration of #326.