Skip to content

Align issue list output with that of pr list#104

Merged
mislav merged 2 commits intomasterfrom
issue-list-table
Nov 25, 2019
Merged

Align issue list output with that of pr list#104
mislav merged 2 commits intomasterfrom
issue-list-table

Conversation

@mislav
Copy link
Copy Markdown
Contributor

@mislav mislav commented Nov 22, 2019

Fixes #103, followup to #82

Screen Shot 2019-11-22 at 5 08 05 PM

@mislav mislav requested a review from ampinsk November 22, 2019 16:18
Copy link
Copy Markdown

@ampinsk ampinsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from design perspective!

@ampinsk ampinsk requested a review from a team November 22, 2019 19:21
Copy link
Copy Markdown
Contributor

@probablycorey probablycorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

name
}
nodes {
name
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 I didn't know there was a nodes shortcut 💥


assigned := convertAPIToIssues(resp.Assigned)
mentioned := convertAPIToIssues(resp.Mentioned)
recent := convertAPIToIssues(resp.Recent)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally did this to avoid having the GraphQL parts of the api leak into our code (specifically the Node bits). But that idea was a bit of interface over-optimization.

@mislav mislav merged commit e59a947 into master Nov 25, 2019
@mislav mislav deleted the issue-list-table branch November 25, 2019 10:24
mislav pushed a commit that referenced this pull request Sep 28, 2021
Append a `*` to the end of a branch name in `ghcs list` if the working
directory of the codespace is dirty (has uncommited or unpushed
changes).

Closes: #104
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent list formatting

3 participants