Skip to content

linux packaging#102

Merged
vilmibm merged 6 commits intomasterfrom
linux-packages
Nov 26, 2019
Merged

linux packaging#102
vilmibm merged 6 commits intomasterfrom
linux-packages

Conversation

@vilmibm
Copy link
Copy Markdown
Contributor

@vilmibm vilmibm commented Nov 21, 2019 •
edited
Loading

This PR:

  • Adds an nfpm section to .goreleaser.yml
  • Builds .deb and .rpm files
  • Adds instructions to README for installing/uninstalling on linux.

Closes #84

@vilmibm
Copy link
Copy Markdown
Contributor Author

vilmibm commented Nov 21, 2019

even with setting bindir i'm getting /usr/local/bin/bin/gh in the end...

@mislav
Copy link
Copy Markdown
Contributor

mislav commented Nov 22, 2019

So great that goreleaser can handle packaging this for us 🎉

Where do we intend for the packaged products to end up?

@vilmibm
Copy link
Copy Markdown
Contributor Author

vilmibm commented Nov 22, 2019

@mislav for now I'm just leaving them on the releases page and telling people to download it manually. If I had more time I'd look into uploading the .debs to a PPA and putting an AUR formula up.

@vilmibm vilmibm requested a review from a team November 22, 2019 21:22
@vilmibm vilmibm changed the title [WIP] linux packaging linux packaging Nov 22, 2019
mislav
mislav approved these changes Nov 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff; love the new documentation.

@vilmibm How did you solve the /usr/local/bin/bin/gh problem?

README.md Outdated

_warning, gh is in a very alpha phase_

## OSX
Copy link
Copy Markdown
Contributor

@mislav mislav Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it should be "macOS", but if this is about Homebrew, then we can say "macOS & Linux with Homebrew" since Homebrew is technically available on both

(our Homebrew formula will currently not work on Linux but we can fix that)

Copy link
Copy Markdown
Contributor Author

@vilmibm vilmibm Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change to macOS and we can add "linux with homebrew" once we adapt the formula

@vilmibm vilmibm merged commit e589262 into master Nov 26, 2019
@vilmibm
Copy link
Copy Markdown
Contributor Author

vilmibm commented Nov 26, 2019

@mislav weirdly the bin issue was indeed resolved with bindir. after changing that i had a build still with the bad path, but after setting up to debug it locally it worked. i'm assuming human error on my part.

@mislav mislav deleted the linux-packages branch November 27, 2019 18:22
mislav pushed a commit that referenced this pull request Sep 28, 2021
Merge pull request #102 from github/fix-12
fee4b48 
remove sleep 1s in ssh subcommand
Stonre pushed a commit to Stonre/strands-fork that referenced this pull request Jul 21, 2025
@awsarron
docs(readme): add logo, title, badges, links to other repos, standard…
aa95e41 
…ize headings (cli#102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub CLI works on Linux

2 participants

@vilmibm @mislav