Skip to content

chore(localizations): Add missing sign-in-or-up titleCombined translation for zh-TW#6701

Merged
wobsoriano merged 3 commits intomainfrom
rob/sign-in-or-up-continue-text-zh-tw
Sep 3, 2025
Merged

chore(localizations): Add missing sign-in-or-up titleCombined translation for zh-TW#6701
wobsoriano merged 3 commits intomainfrom
rob/sign-in-or-up-continue-text-zh-tw

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Sep 3, 2025

Description

Add translation for signIn.start.titleCombined in Traditional Chinese localization file to match the eng version "Continue to {{applicationName}}".

Screenshot 2025-09-03 at 12 51 03 PM

Resolves #6673

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added Traditional Chinese (zh-TW) translation for the combined sign-in/sign-up title, now showing “繼續前往 {{applicationName}}”, improving clarity and consistency for zh-TW users.
  • Chores
    • Prepared a patch release entry for the localization package.

@vercel
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Sep 3, 2025 7:56pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

Walkthrough

A Traditional Chinese localization key was added: in packages/localizations/src/zh-TW.ts, signIn.start.titleCombined was set to "繼續前往 {{applicationName}}". No other localization keys or exports were changed.

Changes

Cohort / File(s) Summary
Localization: zh-TW sign-in titleCombined
packages/localizations/src/zh-TW.ts
Added signIn.start.titleCombined = '繼續前往 {{applicationName}}'; other entries unchanged.
Changeset: release note
.changeset/breezy-coins-heal.md
Added a patch changeset noting the Traditional Chinese translation addition for sign-in/up combined title.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective Addressed Explanation
Provide missing zh-TW translation for "Continue To <MY_APP_NAME>" (#6673)

Poem

I nibble at strings beneath moonlight,
A hop, a patch — one key set right.
"繼續前往" now leads the way,
Apps greet users in zh-TW today.
Tiny change, carrot joy in sight. 🥕🐇


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f87f81d and e0c89f4.

📒 Files selected for processing (1)
  • .changeset/breezy-coins-heal.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/breezy-coins-heal.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: semgrep/ci
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/sign-in-or-up-continue-text-zh-tw

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: e0c89f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6701

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6701

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6701

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6701

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6701

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6701

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6701

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6701

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6701

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6701

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6701

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6701

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6701

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6701

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6701

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6701

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6701

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6701

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6701

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6701

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6701

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6701

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6701

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6701

commit: e0c89f4

@wobsoriano wobsoriano merged commit 6e3f53e into main Sep 3, 2025
39 checks passed
@wobsoriano wobsoriano deleted the rob/sign-in-or-up-continue-text-zh-tw branch September 3, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing translation in zhTW

3 participants