Skip to content

chore(repo): Add workflow to approve integration tests for fork PRs - #4482

Merged
LauraBeatris merged 5 commits into
mainfrom
laura/sdk-1253-share-vars-with-forked-repos-so-lint-and-unit-tests-run-test-2
Nov 5, 2024
Merged

chore(repo): Add workflow to approve integration tests for fork PRs#4482
LauraBeatris merged 5 commits into
mainfrom
laura/sdk-1253-share-vars-with-forked-repos-so-lint-and-unit-tests-run-test-2

Conversation

@LauraBeatris

@LauraBeatris LauraBeatris commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Description

Resolves SDK-1253

Handles a security feature in GitHub Actions - secrets are not shared with workflows running from fork PRs to prevent security vulnerabilities.

To address that:

  • Skip integration tests by default for forked PRs
  • Add workflow to approve integration tests by PR comment: !run-integration-tests

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: CI changes

@LauraBeatris LauraBeatris self-assigned this Nov 4, 2024
@changeset-bot

changeset-bot Bot commented Nov 4, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 379474c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris
LauraBeatris marked this pull request as ready for review November 4, 2024 20:51
@LauraBeatris
LauraBeatris requested a review from a team November 4, 2024 20:52
Comment thread .github/workflows/approve-integration-tests.yml Outdated
@LauraBeatris
LauraBeatris force-pushed the laura/sdk-1253-share-vars-with-forked-repos-so-lint-and-unit-tests-run-test-2 branch 2 times, most recently from e058f25 to 9825271 Compare November 4, 2024 21:39
@tmilewski
tmilewski self-requested a review November 4, 2024 21:41
@LauraBeatris
LauraBeatris force-pushed the laura/sdk-1253-share-vars-with-forked-repos-so-lint-and-unit-tests-run-test-2 branch from 9825271 to 379474c Compare November 4, 2024 21:42
@LauraBeatris
LauraBeatris merged commit 74985fe into main Nov 5, 2024
@LauraBeatris
LauraBeatris deleted the laura/sdk-1253-share-vars-with-forked-repos-so-lint-and-unit-tests-run-test-2 branch November 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants