chore(localizations): nl-NL updates - #4181
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5b4b423 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@alexcarpenter I kept running into package-lock.json problems in the other PR, so I made a new one. Is this one valid? |
tmilewski
self-requested a review
September 17, 2024 14:06
tmilewski
requested changes
Sep 17, 2024
tmilewski
left a comment
tmilewski
left a comment
Member
There was a problem hiding this comment.
@guustgoossens It seems that it's not building due to a type error. Mind checking that out? Thanks a lot!
Error: src/nl-NL.ts(741,9): error TS2561: Object literal may only specify known properties, but 'messageLine2' does not exist in type 'DeepPartial<{ title: string; messageLine1: string; }>'. Did you mean to write 'messageLine1'?
Contributor
Author
should work now! |
tmilewski
self-requested a review
September 17, 2024 17:42
tmilewski
approved these changes
Sep 17, 2024
guustgoossens
marked this pull request as draft
September 17, 2024 23:13
tmilewski
marked this pull request as ready for review
September 18, 2024 17:23
tmilewski
approved these changes
Sep 18, 2024
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change