feat(ui): Sign out of other sessions checkbox - #3801
Merged
Conversation
🦋 Changeset detectedLatest commit: c384a77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alexcarpenter
approved these changes
Jul 24, 2024
alexcarpenter
left a comment
alexcarpenter
left a comment
Member
There was a problem hiding this comment.
Nice. One small non-blocking question around mt usage on the checkbox component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Went back-and-forth on how to implement this – it opens up another future discussion around component composition within Elements – but ultimately decided to go down the route of using
accent-colorfor basic styling at the momentCleanShot.2024-07-24.at.16.43.13.mp4
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change