Skip to content

feat(elements): Add support for signOutOfOtherSessions checkbox - #3779

Closed
alexcarpenter wants to merge 11 commits into
mainfrom
alexcarpenter/sdki-146-signin-reset-password-sign-out-of-all-other-devices-checkbox
Closed

feat(elements): Add support for signOutOfOtherSessions checkbox#3779
alexcarpenter wants to merge 11 commits into
mainfrom
alexcarpenter/sdki-146-signin-reset-password-sign-out-of-all-other-devices-checkbox

Conversation

@alexcarpenter

@alexcarpenter alexcarpenter commented Jul 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Add support for checkbox input usage and signOutOfOtherSessions functionality in sign in password reset flow

Usage:

<Common.Field name="signOutOfOtherSessions">
  <Common.Input type="checkbox" />
  <Common.Label>Sign out of all other devices</Common.Label>
</Common.Field>

https://linear.app/clerk/issue/SDKI-146/signin-reset-password-sign-out-of-all-other-devices-checkbox

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Jul 22, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0ba3550

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter changed the title feat(elements): add support for signOutOfOtherSessions checkbpox feat(elements): add support for signOutOfOtherSessions checkbox Jul 22, 2024
@alexcarpenter alexcarpenter changed the title feat(elements): add support for signOutOfOtherSessions checkbox feat(elements): Add support for signOutOfOtherSessions checkbox Jul 22, 2024
@alexcarpenter
alexcarpenter requested a review from dstaley July 22, 2024 20:55
@joe-bell

joe-bell commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Was about to merge but seems there's been some discussion internally; so I'll hold off clicking the green button until then

@alexcarpenter
alexcarpenter marked this pull request as draft July 23, 2024 12:41
@alexcarpenter
alexcarpenter marked this pull request as ready for review July 23, 2024 15:33
alexcarpenter
alexcarpenter commented Jul 23, 2024
View reviewed changes
Comment thread packages/elements/src/internals/machines/form/form.types.ts
Comment on lines +28 to +39
type:
| 'text'
| 'email'
| 'password'
| 'tel'
| 'number'
| 'date'
| 'time'
| 'datetime-local'
| 'month'
| 'week'
| 'otp';

@alexcarpenter alexcarpenter Jul 23, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought i'd be able to make use of the ClerkInputType type here excluding checkbox, but that surfaced a bunch of type errors in FIELD.ADD and FIELD.UPDATE. Open to suggestions here.

type: Exclude<ClerkInputType, 'checkbox'>

@dstaley dstaley Jul 23, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm totally fine with this being explicit given we probably don't really want to support the entire set of HTMLInputTypeAttribute types.

@alexcarpenter
alexcarpenter marked this pull request as draft July 23, 2024 19:02
@alexcarpenter

alexcarpenter commented Jul 23, 2024

Copy link
Copy Markdown
Member Author

Closing in favor of #3791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstaley dstaley dstaley approved these changes
+1 more reviewer
@panteliselef panteliselef panteliselef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

elements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcarpenter @joe-bell @dstaley @panteliselef @clerk-cookie