fix(backend): Fix `getToken` returning `null` when resolving the handshake payload by anagstef · Pull Request #3764 · clerk/javascript

anagstef · 2024-07-19T00:19:15Z

Description

This PR fixes an issue on Remix where getToken() returns no token when redirecting back when sign-in and handshake are triggered.

The issue exists because the getToken() is getting the session token from the request cookie, but when returning from an external sign-in page (e.g. OAuth or Account Portal) on the request there is still the __clerk_handshake cookie, because it's not yet resolved. The issue exists only on production, and also does not happen to nextjs, because middleware has already resolved the handshake.

With this PR we pass the session token that exists inside the handshake payload to be returned when calling getToken().

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

changeset-bot · 2024-07-19T00:19:19Z

🦋 Changeset detected

Latest commit: cbde650

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@clerk/backend	Patch
@clerk/astro	Patch
@clerk/express	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
@clerk/tanstack-start	Patch
@clerk/testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

anagstef · 2024-07-19T00:19:58Z

!snapshot

clerk-cookie · 2024-07-19T00:24:48Z

Hey @anagstef - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.0.1-snapshot.v7ada807
@clerk/backend	1.4.0-snapshot.v7ada807
@clerk/chrome-extension	1.1.5-snapshot.v7ada807
@clerk/clerk-js	5.10.0-snapshot.v7ada807
@clerk/elements	0.10.5-snapshot.v7ada807
@clerk/clerk-expo	1.2.8-snapshot.v7ada807
@clerk/express	0.0.18-snapshot.v7ada807
@clerk/fastify	1.0.20-snapshot.v7ada807
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/nextjs	5.2.5-snapshot.v7ada807
@clerk/clerk-react	5.2.9-snapshot.v7ada807
@clerk/remix	4.2.4-snapshot.v7ada807
@clerk/clerk-sdk-node	5.0.17-snapshot.v7ada807
@clerk/shared	2.4.0-snapshot.v7ada807
@clerk/tanstack-start	0.1.8-snapshot.v7ada807
@clerk/testing	1.1.12-snapshot.v7ada807

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.0.1-snapshot.v7ada807 --save-exact

@clerk/backend

npm i @clerk/backend@1.4.0-snapshot.v7ada807 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.5-snapshot.v7ada807 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.10.0-snapshot.v7ada807 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.5-snapshot.v7ada807 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.8-snapshot.v7ada807 --save-exact

@clerk/express

npm i @clerk/express@0.0.18-snapshot.v7ada807 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.20-snapshot.v7ada807 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.5-snapshot.v7ada807 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.9-snapshot.v7ada807 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.4-snapshot.v7ada807 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.17-snapshot.v7ada807 --save-exact

@clerk/shared

npm i @clerk/shared@2.4.0-snapshot.v7ada807 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.8-snapshot.v7ada807 --save-exact

@clerk/testing

npm i @clerk/testing@1.1.12-snapshot.v7ada807 --save-exact

anagstef · 2024-07-22T09:29:14Z

!snapshot

clerk-cookie · 2024-07-22T09:34:26Z

Hey @anagstef - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.0.1-snapshot.v94b1fb2
@clerk/backend	1.4.0-snapshot.v94b1fb2
@clerk/chrome-extension	1.1.5-snapshot.v94b1fb2
@clerk/clerk-js	5.10.0-snapshot.v94b1fb2
@clerk/elements	0.10.5-snapshot.v94b1fb2
@clerk/clerk-expo	1.2.8-snapshot.v94b1fb2
@clerk/express	0.0.18-snapshot.v94b1fb2
@clerk/fastify	1.0.20-snapshot.v94b1fb2
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.5.0-snapshot.v94b1fb2
@clerk/nextjs	5.2.5-snapshot.v94b1fb2
@clerk/clerk-react	5.2.9-snapshot.v94b1fb2
@clerk/remix	4.2.4-snapshot.v94b1fb2
@clerk/clerk-sdk-node	5.0.17-snapshot.v94b1fb2
@clerk/shared	2.4.0-snapshot.v94b1fb2
@clerk/tanstack-start	0.1.8-snapshot.v94b1fb2
@clerk/testing	1.2.0-snapshot.v94b1fb2
@clerk/themes	2.1.13-snapshot.v94b1fb2
@clerk/types	4.9.0-snapshot.v94b1fb2

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.0.1-snapshot.v94b1fb2 --save-exact

@clerk/backend

npm i @clerk/backend@1.4.0-snapshot.v94b1fb2 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.5-snapshot.v94b1fb2 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.10.0-snapshot.v94b1fb2 --save-exact

@clerk/elements

npm i @clerk/elements@0.10.5-snapshot.v94b1fb2 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.8-snapshot.v94b1fb2 --save-exact

@clerk/express

npm i @clerk/express@0.0.18-snapshot.v94b1fb2 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.20-snapshot.v94b1fb2 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.5.0-snapshot.v94b1fb2 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.5-snapshot.v94b1fb2 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.2.9-snapshot.v94b1fb2 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.4-snapshot.v94b1fb2 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.17-snapshot.v94b1fb2 --save-exact

@clerk/shared

npm i @clerk/shared@2.4.0-snapshot.v94b1fb2 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.8-snapshot.v94b1fb2 --save-exact

@clerk/testing

npm i @clerk/testing@1.2.0-snapshot.v94b1fb2 --save-exact

@clerk/themes

npm i @clerk/themes@2.1.13-snapshot.v94b1fb2 --save-exact

@clerk/types

npm i @clerk/types@4.9.0-snapshot.v94b1fb2 --save-exact

…shake payload

brkalow

👏

…production

anagstef · 2024-07-23T15:53:09Z

!snapshot

clerk-cookie · 2024-07-23T15:57:38Z

Hey @anagstef - the snapshot version command generated the following package versions:

Package	Version
@clerk/astro	1.0.2-snapshot.vcbde650
@clerk/backend	1.4.1-snapshot.vcbde650
@clerk/chrome-extension	1.1.6-snapshot.vcbde650
@clerk/clerk-js	5.10.1-snapshot.vcbde650
@clerk/clerk-expo	1.2.9-snapshot.vcbde650
@clerk/express	0.0.19-snapshot.vcbde650
@clerk/fastify	1.0.21-snapshot.vcbde650
gatsby-plugin-clerk	5.0.0-beta.45
@clerk/localizations	2.5.1-snapshot.vcbde650
@clerk/nextjs	5.2.6-snapshot.vcbde650
@clerk/remix	4.2.5-snapshot.vcbde650
@clerk/clerk-sdk-node	5.0.18-snapshot.vcbde650
@clerk/tanstack-start	0.1.9-snapshot.vcbde650
@clerk/testing	1.2.1-snapshot.vcbde650

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@1.0.2-snapshot.vcbde650 --save-exact

@clerk/backend

npm i @clerk/backend@1.4.1-snapshot.vcbde650 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@1.1.6-snapshot.vcbde650 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.10.1-snapshot.vcbde650 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@1.2.9-snapshot.vcbde650 --save-exact

@clerk/express

npm i @clerk/express@0.0.19-snapshot.vcbde650 --save-exact

@clerk/fastify

npm i @clerk/fastify@1.0.21-snapshot.vcbde650 --save-exact

gatsby-plugin-clerk

npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact

@clerk/localizations

npm i @clerk/localizations@2.5.1-snapshot.vcbde650 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@5.2.6-snapshot.vcbde650 --save-exact

@clerk/remix

npm i @clerk/remix@4.2.5-snapshot.vcbde650 --save-exact

@clerk/clerk-sdk-node

npm i @clerk/clerk-sdk-node@5.0.18-snapshot.vcbde650 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.1.9-snapshot.vcbde650 --save-exact

@clerk/testing

npm i @clerk/testing@1.2.1-snapshot.vcbde650 --save-exact

nikosdouvlis

This makes sense to me 👍🏻

…shake payload (#3764) This PR fixes an issue on Remix where getToken() returns no token when redirecting back when sign-in and handshake are triggered. The issue exists because the getToken() is getting the session token from the request cookie, but when returning from an external sign-in page (e.g. OAuth or Account Portal) on the request there is still the __clerk_handshake cookie, because it's not yet resolved. The issue exists only on production, and also does not happen to nextjs, because middleware has already resolved the handshake. With this PR we pass the session token that exists inside the handshake payload to be returned when calling getToken().

anagstef self-assigned this Jul 19, 2024

clerk-cookie added nextjs backend labels Jul 19, 2024

anagstef force-pushed the stefanos/eco-51-gettoken-null-in-production branch from 7ada807 to 94b1fb2 Compare July 22, 2024 09:28

fix(backend): Fix getToken returning null when resolving the hand…

d7dc9e1

…shake payload

anagstef force-pushed the stefanos/eco-51-gettoken-null-in-production branch from 94b1fb2 to d7dc9e1 Compare July 22, 2024 12:01

Add tests

87bf6b6

anagstef requested review from brkalow, dimkl and nikosdouvlis July 22, 2024 17:50

anagstef marked this pull request as ready for review July 22, 2024 17:50

Update dry-yaks-buy.md

29ff802

brkalow approved these changes Jul 23, 2024

View reviewed changes

Merge branch 'refs/heads/main' into stefanos/eco-51-gettoken-null-in-…

cbde650

…production

nikosdouvlis approved these changes Jul 23, 2024

View reviewed changes

dimkl approved these changes Jul 23, 2024

View reviewed changes

anagstef merged commit d465d70 into main Jul 23, 2024

anagstef deleted the stefanos/eco-51-gettoken-null-in-production branch July 23, 2024 21:23

clerk-cookie mentioned this pull request Jul 23, 2024

ci(repo): Version packages #3790

Merged

Navigation Menu

Uh oh!

fix(backend): Fix `getToken` returning `null` when resolving the handshake payload - #3764

fix(backend): Fix `getToken` returning `null` when resolving the handshake payload#3764
anagstef merged 4 commits into
mainfrom
stefanos/eco-51-gettoken-null-in-production

anagstef commented Jul 19, 2024 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 19, 2024 •

edited

Loading

Uh oh!

anagstef commented Jul 19, 2024

Uh oh!

clerk-cookie commented Jul 19, 2024

Uh oh!

anagstef commented Jul 22, 2024

Uh oh!

clerk-cookie commented Jul 22, 2024

Uh oh!

brkalow left a comment

Uh oh!

anagstef commented Jul 23, 2024

Uh oh!

clerk-cookie commented Jul 23, 2024

Uh oh!

nikosdouvlis left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

anagstef commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

anagstef commented Jul 19, 2024

Uh oh!

clerk-cookie commented Jul 19, 2024

Uh oh!

anagstef commented Jul 22, 2024

Uh oh!

clerk-cookie commented Jul 22, 2024

Uh oh!

brkalow left a comment

Choose a reason for hiding this comment

Uh oh!

anagstef commented Jul 23, 2024

Uh oh!

clerk-cookie commented Jul 23, 2024

Uh oh!

nikosdouvlis left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anagstef commented Jul 19, 2024 •

edited

Loading

changeset-bot Bot commented Jul 19, 2024 •

edited

Loading