Skip to content

chore(clerk-js): Fix issue where checkbox styling seems broken - #2995

Merged
nikosdouvlis merged 4 commits into
mainfrom
vaggelis/sdk-1504-checkbox-on-set-new-password-page-is-a-bit-off
Mar 14, 2024
Merged

chore(clerk-js): Fix issue where checkbox styling seems broken#2995
nikosdouvlis merged 4 commits into
mainfrom
vaggelis/sdk-1504-checkbox-on-set-new-password-page-is-a-bit-off

Conversation

@octoper

@octoper octoper commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes a styling issue for checkboxes, where it appears that the checkbox is not working at all when clicked, the issue is caused by another fix we applied couple days ago to fix some other issues with inputs on iOS =< 16

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Mar 14, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1119c7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper

octoper commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

!preview

@clerk-cookie

clerk-cookie commented Mar 14, 2024

Copy link
Copy Markdown
Collaborator

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Mar 14, 2024 12:36 PM

@octoper

octoper commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

!preview

@octoper

octoper commented Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

!preview

@octoper
octoper marked this pull request as ready for review March 14, 2024 13:16
@octoper
octoper requested a review from anagstef March 14, 2024 13:16
@octoper octoper self-assigned this Mar 14, 2024
@octoper
octoper requested a review from brkalow March 14, 2024 13:17
@nikosdouvlis
nikosdouvlis merged commit 2684f1d into main Mar 14, 2024
@nikosdouvlis
nikosdouvlis deleted the vaggelis/sdk-1504-checkbox-on-set-new-password-page-is-a-bit-off branch March 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants