chore(repo): Update lock file on version PR - #2989
Merged
Merged
Conversation
|
LekoArts
commented
Mar 13, 2024
Contributor
Author
There was a problem hiding this comment.
This file wasn't used anywhere
LekoArts
marked this pull request as ready for review
March 13, 2024 10:10
nikosdouvlis
approved these changes
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's this changesets issue: changesets/changesets#421
When our "Version packages" PR is merged the lock file is not updated. This PR changes the GitHub action to run
npm run versioninstead ofchangeset version. Our custom scripts usesnpm install --lock-file-only(https://docs.npmjs.com/cli/v10/commands/npm-install#package-lock-only) to update the lock file after the individualpackage.jsonfiles are changed.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change