Skip to content

fix(*): Update dependencies to resolve security alerts - #2983

Merged
dimkl merged 2 commits into
mainfrom
sdk-1491-fix-dependabot
Mar 15, 2024
Merged

fix(*): Update dependencies to resolve security alerts#2983
dimkl merged 2 commits into
mainfrom
sdk-1491-fix-dependabot

Conversation

@dimkl

@dimkl dimkl commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Description

Investigate and fix dependabot security alerts and results from npm audit.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@dimkl
dimkl requested a review from nikosdouvlis March 12, 2024 17:21
@dimkl dimkl self-assigned this Mar 12, 2024
@changeset-bot

changeset-bot Bot commented Mar 12, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4489e88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/expo/package.json
Comment thread packages/nextjs/package.json
Comment thread packages/backend/package.json Outdated
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch from a0a82cb to 0e64341 Compare March 13, 2024 12:20
@dimkl
dimkl requested review from LekoArts and anagstef March 13, 2024 12:20
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch 3 times, most recently from 769f6d0 to 6446c22 Compare March 13, 2024 12:44
@dimkl

dimkl commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

I had some issues with "List node_modules" of our GH action when updating the miniflare and tslib libraries. I resolved it by installing those packages specifically in each package directory.
Screenshot 2024-03-13 at 15 28 40

Example run: https://github.com/clerk/javascript/actions/runs/8264832463/job/22609252010?pr=2983

@dimkl

dimkl commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

I changed the miniflare to 2.4.12 instead of 3.20240304.0 since the tests broke due to the following error:

Disallowed operation called within global scope. Asynchronous I/O (ex: fetch() or connect())....

Comment thread integration/templates/next-app-router/package.json Outdated
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch from ca4ef70 to fe4c895 Compare March 13, 2024 14:29
Comment thread packages/expo/package.json
Comment thread packages/expo/package.json
@dimkl dimkl changed the title fix(*): Update dependencies to resolve secutiry alerts fix(*): Update dependencies to resolve security alerts Mar 13, 2024
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch from fe4c895 to f7b8416 Compare March 14, 2024 18:47
@dimkl
dimkl requested a review from anagstef March 14, 2024 18:54
},
"peerDependencies": {
"next": "^13.0.4 || ^14.0.3",
"next": "^13.5.4 || ^14.0.3",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a "breaking" change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikosdouvlis yes, kind of.
if this is for the changeset entry, i guess it's better to change it to major. Since we are in a pre-release tag, it's okay.
I think that customers who want to Clerk with NextJS in production would probably have a newer @13 version with all the security updates.
Wdyt?

Comment thread packages/elements/package.json Outdated
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch from 6cf840e to 7b7cbfb Compare March 15, 2024 10:15
Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.
@dimkl
dimkl force-pushed the sdk-1491-fix-dependabot branch from 7b7cbfb to 4489e88 Compare March 15, 2024 10:34
@dimkl
dimkl enabled auto-merge (squash) March 15, 2024 10:39
@dimkl
dimkl merged commit 980a56c into main Mar 15, 2024
@dimkl
dimkl deleted the sdk-1491-fix-dependabot branch March 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants