Skip to content

feat(backend): Create SamlConnectionApi and SamlConnection resource - #2980

Merged
nikosdouvlis merged 8 commits into
mainfrom
emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks
Mar 15, 2024
Merged

feat(backend): Create SamlConnectionApi and SamlConnection resource#2980
nikosdouvlis merged 8 commits into
mainfrom
emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks

Conversation

@EmmanouelaPothitou

@EmmanouelaPothitou EmmanouelaPothitou commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Description

Expose any BAPI SAML Connection endpoints as part of every Clerk BE SDK

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Mar 12, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 23a4e08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/backend/src/api/resources/SamlConnection.ts Outdated
Comment thread packages/backend/src/api/endpoints/SamlConnectionApi.ts Outdated
Comment thread packages/backend/src/api/endpoints/SamlConnectionApi.ts Outdated
@EmmanouelaPothitou
EmmanouelaPothitou force-pushed the emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks branch from ac3b059 to df27a55 Compare March 13, 2024 12:04

@chanioxaris chanioxaris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Also it seems like there are some commits included not related to our changes here

Comment thread packages/backend/src/api/endpoints/SamlConnectionApi.ts
Comment thread packages/backend/src/api/endpoints/SamlConnectionApi.ts
Comment thread packages/backend/src/api/resources/AttributeMapping.ts Outdated
Comment thread packages/backend/src/api/resources/SamlConnection.ts
@EmmanouelaPothitou
EmmanouelaPothitou force-pushed the emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks branch from 7ca8298 to a032f3e Compare March 14, 2024 13:59

@nikosdouvlis nikosdouvlis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chanioxaris chanioxaris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

Comment thread packages/backend/src/api/resources/SamlConnection.ts Outdated
Co-authored-by: Haris Chaniotakis <chanioxaris@gmail.com>
@EmmanouelaPothitou
EmmanouelaPothitou force-pushed the emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks branch from d99e28f to 23a4e08 Compare March 15, 2024 10:57
@nikosdouvlis
nikosdouvlis merged commit 8c23651 into main Mar 15, 2024
@nikosdouvlis
nikosdouvlis deleted the emmanouela/core-1637-expose-saml-connection-operations-on-the-rest-sdks branch March 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants