feat(clerk-js): Throw errors for invalid mounts/modal opens in development - #2976
Merged
desiprisg merged 1 commit intoMar 20, 2024
Conversation
🦋 Changeset detectedLatest commit: 61c4a96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Mar 12, 2024
desiprisg
force-pushed
the
george/sdk-1445-throw-a-clear-error-when-org-components-are-used-but
branch
2 times, most recently
from
March 13, 2024 10:08
3bb537a to
5112bde
Compare
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
Added some suggestions for the code names
desiprisg
force-pushed
the
george/sdk-1445-throw-a-clear-error-when-org-components-are-used-but
branch
from
March 20, 2024 09:20
5112bde to
f29dd68
Compare
desiprisg
enabled auto-merge (squash)
March 20, 2024 09:22
desiprisg
force-pushed
the
george/sdk-1445-throw-a-clear-error-when-org-components-are-used-but
branch
from
March 20, 2024 11:40
f29dd68 to
61c4a96
Compare
desiprisg
deleted the
george/sdk-1445-throw-a-clear-error-when-org-components-are-used-but
branch
March 20, 2024 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
console.infoin cases where the mounting of a component or opening of a modal is not supposed to happen (in development). Render nothing in production without an error or warning.withOrganizationsEnabledGuardHOC as it did not have any effect since theclerkmethod protections were introduced.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change