fix(clerk-js): Fix custom page rerendering issues - #2897
Merged
anagstef merged 2 commits intoMar 1, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 2621e9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Let's add the changeset once we verify why this fix works. |
Contributor
|
@desiprisg Good job! This fix works. I'll resolve the conflicts and add a changeset! |
anagstef
force-pushed
the
george/sdk-1420-custom-user-profile-pages-with-user-button-is-causing
branch
from
March 1, 2024 13:11
575ffd0 to
2621e9f
Compare
anagstef
approved these changes
Mar 1, 2024
anagstef
enabled auto-merge
March 1, 2024 13:13
anagstef
added this pull request to the merge queue
Mar 1, 2024
anagstef
deleted the
george/sdk-1420-custom-user-profile-pages-with-user-button-is-causing
branch
March 1, 2024 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding this memoization seems to fix both icon flickering and infinite rerender on the modal version. Not sure why. Content of the page is still mutable so no functionality seems to be affected. @anagstef I'd appreciate if you could verify why this change works as I'm not that familiar with this feature implementation.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change