fix(nextjs): Fix Protect type - #2373
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8a13642 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SokratisVidros
approved these changes
Dec 15, 2023
dimkl
approved these changes
Dec 15, 2023
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 15, 2023 16:37
06d2a9d to
5de3829
Compare
panteliselef
approved these changes
Dec 15, 2023
panteliselef
left a comment
panteliselef
left a comment
Contributor
There was a problem hiding this comment.
Is this something that needs to go to v4 ? Or was caused by other recent changes after the release ?
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 15, 2023 18:56
5de3829 to
b3fa4b3
Compare
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
4 times, most recently
from
December 15, 2023 19:56
4359fef to
9343eb5
Compare
| return userId ? null : <>{children}</>; | ||
| } | ||
|
|
||
| type ProtectServerComponentProps = React.ComponentProps<typeof ProtectClientComponent>; |
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 16, 2023 02:41
9343eb5 to
f353ac2
Compare
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
2 times, most recently
from
December 16, 2023 02:49
1dbaa81 to
281308b
Compare
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 16, 2023 19:26
3116a3a to
6f2c17a
Compare
dimkl
reviewed
Dec 18, 2023
dimkl
reviewed
Dec 18, 2023
SokratisVidros
approved these changes
Dec 18, 2023
dimkl
approved these changes
Dec 18, 2023
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 18, 2023 10:50
6f2c17a to
75d0a25
Compare
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
3 times, most recently
from
December 18, 2023 11:13
7046c23 to
6ba6482
Compare
…esolution set to "node"
nikosdouvlis
force-pushed
the
nikos/fix-next-integration
branch
from
December 18, 2023 11:17
6ba6482 to
2581524
Compare
This reverts commit bbb9b66.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review commit by commit
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore