fix(repo): Ensure build runs before lint in CI - #1902
Conversation
🦋 Changeset detectedLatest commit: 5887755 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }, | ||
| "lint": { | ||
| "dependsOn": [], | ||
| "dependsOn": ["build"], |
There was a problem hiding this comment.
Several lint rules depend on types being available for local packages, this ensures they are. Going forward, we might want to split linting into type-aware and not type-aware to optimize this (cc @nikosdouvlis).
There was a problem hiding this comment.
Spot on Bryce. Expanding a little on the above, the general idea is that we want cheap jobs to run and possibly fail early, before other more expensive operations like package building, unit and integration tests etc.
nikosdouvlis
left a comment
nikosdouvlis
left a comment
There was a problem hiding this comment.
Very good job spotting this @brkalow
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Description
Our lint step is type-aware, and our internal dependencies rely on packages being built for types to be correctly available. I've updated the lint step in CI to rely on
buildso that the types should be available as expected.I've also shifted the turbo cache interaction into our shared setup action. We can opt-in to restoring the turbo cache by passing
use-turbo-cache: 'true'.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore