Feat(backend, nextjs): introduce redirectToSignIn / redirectToSignup helper - #1108
Merged
Conversation
JS-71 Create redirectToSignUp and redirectToSignIn in backend
For use in the "page protection" snippet for middleware Initial details: https://www.notion.so/clerkdev/Repo-level-path-configuration-for-ClerkJS-V4-38fb154df5cd4d7395031a1dbc200213#f3d498163c8a46859ed97efa07bcb305 Final details: https://clerkinc.slack.com/archives/C053Y388ZNE/p1682504392924589?thread_ts=1682497153.327009&cid=C053Y388ZNE |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
Contributor
Author
|
Ignore the failing tests. They are related to the addition of |
anagstef
approved these changes
Apr 26, 2023
SokratisVidros
suggested changes
Apr 26, 2023
dimkl
force-pushed
the
js-71-backend-signup-signin-redirect
branch
2 times, most recently
from
April 27, 2023 10:08
baf1590 to
8abe1a2
Compare
SokratisVidros
approved these changes
Apr 27, 2023
dimkl
force-pushed
the
js-71-backend-signup-signin-redirect
branch
from
April 27, 2023 16:18
6469ac6 to
9fec947
Compare
This is used to test the client side navigation of NextJS
…ngPublishableKeyError message
dimkl
force-pushed
the
js-71-backend-signup-signin-redirect
branch
from
April 27, 2023 16:29
9fec947 to
ab3fcaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Introduced
redirectToSignIn/redirectToSignuphelper in@clerk/backendpackage and a wrapper of those in@clerk/nextjsto support a better DX for redirecting to sing-in and sign-up pages.The new NextJS helpers are gonna work as :
Some key notes:
redirectBackUrlis optionalNotes
Review it per commit