build gtest with an external project#73
Merged
TimmyLiu merged 1 commit intoclMathLibraries:developfrom Mar 25, 2015
Merged
Conversation
glehmann
force-pushed
the
gtest-external
branch
from
c7962ba to
14fbe24
Compare
TimmyLiu
pushed a commit
that referenced
this pull request
Mar 25, 2015
build gtest with an external project
Contributor
|
It looks like the gtest external will be build even when a user didn't choose BUILD_TEST. I wonder if this is okay. I guess to fully disable building gtest one would have to click USE_SYSTEM_GTEST as well. |
Contributor
Author
|
USE_SYSTEM_GTEST can be used, but your right it would be better to not build gtest when the tests are not built. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.