Always cast get_*_* to uints before casting to vectors.#65
Merged
TimmyLiu merged 1 commit intoclMathLibraries:developfrom Feb 16, 2015
Merged
Always cast get_*_* to uints before casting to vectors.#65TimmyLiu merged 1 commit intoclMathLibraries:developfrom
TimmyLiu merged 1 commit intoclMathLibraries:developfrom
Conversation
Contributor
pavanky
commented
Feb 13, 2015
pavanky
commented
- Fixes issues with on intel SDKs on Windows, Apple SDKs on OSX
- Fixes Sgemm crashes on Intel Platform when transA is false and transB is true #62
- Fixes issues with on intel SDKs on Windows, Apple SDKs on OSX
Contributor
|
Hi Pavan, Thanks for fixing this bug. Can you verify one thing for me that c/zgemm are not broken. I remember a while back some one in issue #53 was trying to fix a similar bug but it broke cgemm. Can you just run a full short test on your system with "./test-short --gtest_filter=gemm"? |
Contributor
Author
|
I ran Do you want me to explicitly test on anything else ? |
TimmyLiu
pushed a commit
that referenced
this pull request
Feb 16, 2015
Always cast get_*_* to uints before casting to vectors.
Contributor
|
thanks! Just being precautions. I merged the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.