fix for CRM-13374 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2013 15:58
---------------------------------------- * CRM-13374: Select Event invalidation http://issues.civicrm.org/jira/browse/CRM-13374
---------------------------------------- * CRM-13374: Select Event invalidation http://issues.civicrm.org/jira/browse/CRM-13374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the bug mentioned in the issue i.e. now, the "closed" events will also appear in the select box when we create or edit a "CiviCRM Event Information Page" menu item using joomla.
I checked the fix on joomla 2.5.x. It works fine. But, when I tried checking on Joomla 3.x, I found altogether a different bug. The bug was that after creating
"CiviCRM Event Information Page" menu item for a particular event, when I go and click on this menu link in the joomla site, a blank page appears (Event info page is the expected page). I did some debug and found that in civicrm/joomla/sites/civicrm.php, within civicrm_invoke function, "$_GET" was being used to build the $args array(which is required for invoking the respective page."civicrm/event/info" page in our case). The problem is that "$_GET" is not getting populated in Joomla 3.x. I checked online and found some similar issues related to Joomla 3.x like http://www.joomlapolis.com/forum/277-cbsubs-gpl-support/219260-3881-bug-on-cbsubs-content-with-joomla-30-and-sef and http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29540 where people have reported about $_GET not getting populated.
So, I have made the fix by using $_REQUEST to build $args array. The fix is as follows:
ravishnair@556adb3