Skip to content

Conversation

@huazhihao
Copy link
Contributor

No description provided.

git-coverage Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're passing in a key you should also pass in the section rather than hardcode it.

git-coverage Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also requested a list of the files that were skipped and a list of the files which were found to be fully covered - a print statement here will easily show the files that are skipped, but you'll need to add logic after line 812 to print when a file was fully covered

@huazhihao huazhihao changed the title Read and apply omit patterns Show omitted and fully covered files Oct 19, 2016
git-coverage Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use ascii colouring here - much of the output is going to be in log files, so using colouring makes the text harder to read.
You could have "SKIPPING FILE: %s" to highlight it

git-coverage Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a file has several patches, this is going to print multiple times for that file.
This shouldn't be done on a per-patch basis.

setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nothing to do with the pull request of printing omitted files - submit a new pull request.

setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to be venv-safe? How should this work if you're installing in a venv?

@BobBall BobBall merged commit 6f79692 into master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants