-
Notifications
You must be signed in to change notification settings - Fork 0
Show omitted and fully covered files #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
git-coverage
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're passing in a key you should also pass in the section rather than hardcode it.
git-coverage
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also requested a list of the files that were skipped and a list of the files which were found to be fully covered - a print statement here will easily show the files that are skipped, but you'll need to add logic after line 812 to print when a file was fully covered
git-coverage
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't use ascii colouring here - much of the output is going to be in log files, so using colouring makes the text harder to read.
You could have "SKIPPING FILE: %s" to highlight it
git-coverage
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a file has several patches, this is going to print multiple times for that file.
This shouldn't be done on a per-patch basis.
setup.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nothing to do with the pull request of printing omitted files - submit a new pull request.
setup.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be venv-safe? How should this work if you're installing in a venv?
No description provided.