Open
Conversation
Member
|
Is there good motivation behind all the whitespace changes? It really makes the pull request difficult to read. I was trying to keep the style of the original project |
Author
|
I just format code by clang-format when fixes this, but repository haven't any .clang-format file for convert back, so I uses most familiar style - mozilla. Sorry about this. |
Author
|
Wath about add .clang-format file with custom style to repository? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here was seweral bugs and memoryleaks, so I fix that. Most serious bug - with boundingRect on NodeGraphicsObject and ConnectionGraphicsObject. If you change location of some node, and set new connection from it (for example) you can gеt error - usage pure virtual method. I set geometry classes as freands of graphics classes and fix that. Also here was bug with resizing of node - I change sequance of methods and now position of proxywidget set AFTER recalculate of size.