Enable process mode by default & improve profile label handling #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Previously, profiles added from a URL would display a numeric ID as their name because the label was null. This PR sets the profile `label` from the file name in the URL path. If the file name cannot be determined, it falls back to the generated numeric ID. ### Changes - addProfileFormURL now extracts filename from URL for the profile label - UI will display profile.label instead of profile.id
- Added `_getLabelFromURL` to extract profile names from raw, short, or sub-link URLs. - Replaces unsafe characters and query params with readable names. - Truncates names to a max length (default 50) to prevent UI and file system issues. - Falls back to unique ID if parsing fails.
…heuristic short link detection - Detect short links using host length, path segments, or total URL length - Preserve GitHub raw link handling - Default to host + last path segment for normal URLs - Return empty string if label cannot be determined
Change default `FindProcessMode` from `off` to `on` since many rulesets depend on process mode for correct matching and routing.
Change default `FindProcessMode` from `off` to `on` since many rulesets depend on process mode for correct matching and routing.
Change default `FindProcessMode` from `off` to `on` since many rulesets depend on process mode for correct matching and routing.
asgharkapk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FindProcessModedefaulted tooff.onfor better out-of-the-box compatibility.labelwas null.Changes
@Default(FindProcessMode.off)→@Default(FindProcessMode.always).addProfileFormURLto extract the filename from the URL and assign it as the profile label.profile.labelinstead ofprofile.id.Impact