Issue #12847: Compare test violations without order - #21553
Open
rupeshkumar92a-arch wants to merge 1 commit into
Open
Issue #12847: Compare test violations without order#21553rupeshkumar92a-arch wants to merge 1 commit into
rupeshkumar92a-arch wants to merge 1 commit into
Conversation
rupeshkumar92a-arch
force-pushed
the
codex/issue-12847
branch
from
September 11, 2026 16:13
1f11ec2 to
c2b1063
Compare
rupeshkumar92a-arch
force-pushed
the
codex/issue-12847
branch
from
September 11, 2026 17:10
c2b1063 to
3238f9b
Compare
romani
requested changes
Sep 13, 2026
| .that(actualViolations.get(index)) | ||
| .matches(testInputViolations.get(index).toRegex()); | ||
| } | ||
| /* package */ static void verifyViolations(String file, |
Member
There was a problem hiding this comment.
lets make it private.
test for this methods was good to looks at, but we should not preserve them.
Member
|
backup of test that proved that new methods in Google truth are actually covers all: |
Member
|
@rupeshkumar92a-arch , please share maven output of test failures when:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12847
AbstractModuleTestSupportpreviously compared expected and actual violations by list position. Tests with multiple violations on the same line therefore had to understand and reproduce the internal event ordering.Compare the two collections through their existing violation-message patterns without requiring the lists to have the same order. The comparison remains one-to-one, so missing, unexpected, duplicate, wrong-line, and wrong-message violations still fail.
Validation:
./mvnw -ntp clean verify../mvnw -ntp verify -DskipTestspassed on the final commit, including Checkstyle and PMD validation.