Skip to content

Issue #8312: Add Tokens in NoWhitespaceAfterCheck - #21551

Merged
romani merged 1 commit into
checkstyle:masterfrom
ZaheerAhmadDev:tokenadd
Sep 14, 2026
Merged

Issue #8312: Add Tokens in NoWhitespaceAfterCheck#21551
romani merged 1 commit into
checkstyle:masterfrom
ZaheerAhmadDev:tokenadd

Conversation

@ZaheerAhmadDev

@ZaheerAhmadDev ZaheerAhmadDev commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #8312
Closes #20202
Updated getAcceptableTokens() in NoWhitespaceAfterCheck to add new tokens.

New module config: https://gist.githubusercontent.com/ZaheerAhmadDev/8f97674b6339dee6bd85218d80d85ae9/raw/2f305ce33a2bfcd6b39204d07a0be85389ef250b/my_check.xml

@romani romani mentioned this pull request Sep 13, 2026
Closed
@romani

romani commented Sep 13, 2026

Copy link
Copy Markdown
Member

@ZaheerAhmadDev , please do diff testing with new tokens, special configs are required to be created and placed in PR decription

@romani

romani commented Sep 13, 2026

Copy link
Copy Markdown
Member

Github, generate report for NoWhitespaceAfter/all-examples-in-one

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Report for NoWhitespaceAfter/all-examples-in-one:
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/diff/5d6e4ca964d3304e012589fda2de25f4b1dcd6a0_2026235109/index.html

@romani

romani commented Sep 14, 2026

Copy link
Copy Markdown
Member

Ok, no changes in behavior if such tokens are not in use.

@ZaheerAhmadDev , please finish diff testing with new tokens

@ZaheerAhmadDev

ZaheerAhmadDev commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

GitHub, generate report

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Report generation failed on phase make_report,
step Generate report.
Link: https://github.com/checkstyle/checkstyle/actions/runs/34795352208

@ZaheerAhmadDev

ZaheerAhmadDev commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

GitHub, generate report

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Report generation failed on phase make_report,
step Generate report.
Link: https://github.com/checkstyle/checkstyle/actions/runs/34795841511

@ZaheerAhmadDev

ZaheerAhmadDev commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

GitHub, generate report

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/diff/5d6e4ca_2026020846/index.html

romani
romani approved these changes Sep 14, 2026
View reviewed changes

@romani romani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All goot

@romani
romani merged commit d5a5940 into checkstyle:master Sep 14, 2026
133 checks passed
@ZaheerAhmadDev
ZaheerAhmadDev deleted the tokenadd branch September 14, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romani romani romani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NoWhitespaceAfter: Allow for use of DO_WHILE, LITERAL_CATCH, LITERAL_FOR, LITERAL_IF, and LITERAL_WHILE

2 participants

@ZaheerAhmadDev @romani