Skip to content

Conversation

@matrei
Copy link

@matrei matrei commented Sep 12, 2025

Issue #17393

Contribution PR: checkstyle/contribution#970

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CI validations, all should be green.

We would need PR to contribution repository to add new check in regression testing.

You can look at other New module PRs to see how to do this.

Example: #16946

@matrei matrei force-pushed the type-body-padding branch 5 times, most recently from 399a396 to 8c0a608 Compare September 15, 2025 11:33
@matrei matrei force-pushed the type-body-padding branch 2 times, most recently from f796864 to f4cd38f Compare September 15, 2025 13:42
@matrei
Copy link
Author

matrei commented Sep 15, 2025

Please follow CI validations, all should be green.

There is one remaining failure. Is that depending on the contribution PR being merged?

We would need PR to contribution repository to add new check in regression testing.

Done: checkstyle/contribution#970

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start diff testing in real projects..
Items

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

</head>
<body>
<section name="TypeBodyPadding">
<p>Since Checkstyle 11.1</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11.1.0

we have 3 digits in versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do 11.2.0

11.1.0 will be done on Sunday, in 2 days, I don't think you will be ready

@romani
Copy link
Member

romani commented Sep 18, 2025

GitHub, generate website

@romani
Copy link
Member

romani commented Sep 18, 2025

please start testing on real code, please pay attentiont to New module config in description of #16946 , we need "same" for your new check and report generation will be automatic , see how to trigger it #16946 (comment) .
here is doc on how github action is working: https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#executing-generation-using-github-action

@romani
Copy link
Member

romani commented Sep 19, 2025

Please add

static class Inner {
    int b = 0; // violation 'A blank line is required after the opening'
  }

To all examples. We try to keep java code the same, to let users see how comments with violations are changing

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CI violations and fix them. Let me know if you need help.
Run mvn clean verify before pushing, it helps to catch most

One more quick look:


// xdoc section -- start
public class Example5 { // violation 'A blank line is required after the opening'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird, crazy class by design.
It looks weird that this property is to cover this crazy code.
What you trying to cover are cases like:

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)          
public @interface MyMarkerAnnotation {}

https://www.baeldung.com/java-custom-annotation#1-class-level-annotation-example

Please add inner annotation declaration to all examples.
Example5 should be same by code (not a comments) as all others.

@romani
Copy link
Member

romani commented Sep 26, 2025

Please add to test Inputs cases with interface, record, enum. We need diversity.

Please add to also case when class is declared in method body, just to see how Chevk will behave on such potential code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants