Add extra TextStyle and ComponentTextStyle properties#32
Open
dabley wants to merge 5 commits intochapter-three:masterfrom
Open
Add extra TextStyle and ComponentTextStyle properties#32dabley wants to merge 5 commits intochapter-three:masterfrom
dabley wants to merge 5 commits intochapter-three:masterfrom
Conversation
As well as strings representing named font weights, the fontWeight property can also be an integer. Note that Apple News does not allow an integer fontWeight to be given as a string.
This allows the linkStyle property to be set easily with values from a config entity object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add support for a number of additional TextStyle and ComponentTextStyle properties:
Extra TextStyle properties:
Extra ComponentTextStyle properties:
The TextStyle::fontWeight property is allowed to be a string or an integer, so that it can be set to a named font weight (e.g. "medium") or a numeric one (e.g. 500). (Applenews doesnt allow numeric font weights to be supplied as strings - so "500" is not valid.)
The ComponentTextStyle::linkStyle property can now optionally be set using an array, which makes things easier when creating a ComponentTextStyle object.