Conversation
🦋 Changeset detectedLatest commit: d0f9d83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| root.path, | ||
| isWindows ? `${command}.cmd` : command, | ||
| ); | ||
| const shim = isWindows |
There was a problem hiding this comment.
idea: we could depend on nushell for the end to end tests instead of relying on whatever shell is installed on the system
i've been using nushell as my login shell for the last 6 years and can highly recommend it for cross-platform use
| if (!interactive) { | ||
| const detectWebAuth = () => { | ||
| if ( | ||
| observedStdout.includes(webAuthPrompt) || | ||
| observedStderr.includes(webAuthPrompt) | ||
| ) { | ||
| webAuthDetected = true; | ||
| publishProcess.kill(); | ||
| } | ||
| }; | ||
| publishProcess.process?.stdout?.on("data", (chunk: Buffer | string) => { | ||
| observedStdout += chunk.toString(); | ||
| detectWebAuth(); | ||
| }); | ||
| publishProcess.process?.stderr?.on("data", (chunk: Buffer | string) => { | ||
| observedStderr += chunk.toString(); | ||
| detectWebAuth(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
what is happening here? is this to handle a 2fa flow that they do not do well?
| code: statusCode ? `E${statusCode}` : undefined, | ||
| message: output.trim() || undefined, | ||
| }; | ||
| } |
There was a problem hiding this comment.
any chance to add these to the publish snapshot repo? it would make it easier to understand the parsing
2 participants
No description provided.