upgrade eslint to v10 and update config#1876
upgrade eslint to v10 and update config#1876beeequeue wants to merge 17 commits intochangesets:nextfrom
Conversation
|
beeequeue
force-pushed
the
eslint10
branch
2 times, most recently
from
456ac69 to
060529c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1876 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 53 53
Lines 2382 2382
Branches 697 696 -1
=======================================
Hits 1965 1965
Misses 375 375
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This predates my involvement with the project ;p it was just a preference of some of the previous maintainers or smth. |
|
then i'll mark it as a follow-up pr as well 😄 |
packages/cli/src/index.ts
Outdated
|
|
||
| ## Versions | ||
|
|
||
| - @changesets/cli@${ |
There was a problem hiding this comment.
this is something that tsdown could handle very well:
import manifest from "@changesets/cli/package.json" with { type: "json }
export const foo = `@changesets/cli@${manifest.version}`compiles to
const manifest = {
version: "0.0.0",
}
export const foo = `@changesets/cli@${manifest.version}`or maybe even this, but probably only if minifying the output
export const foo = `@changesets/cli@0.0.0`There was a problem hiding this comment.
... this does of course assume one builds the package after upping the versions and publishing
|
@beeequeue could you sync this with |
|
i'm thinking we should merge this after #1879 since it touches a lot of files and the rebase would likely be quite a task if this one was merged first, while rebasing this pr is just re-running eslint fix on the conflicting files |
3 participants
part of #1869
TODO enable and fix errorswhich are good to have but have too many errors and will be fixed in follow-up PRs.git-blame-ignore-revsfile in the follow-up PRs.