Add --strict option to status command#1721
Open
jonatanschroeder wants to merge 2 commits intochangesets:mainfrom
Open
Add --strict option to status command#1721jonatanschroeder wants to merge 2 commits intochangesets:mainfrom
jonatanschroeder wants to merge 2 commits intochangesets:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 40c14bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage ? 80.79%
=======================================
Files ? 54
Lines ? 2270
Branches ? 684
=======================================
Hits ? 1834
Misses ? 431
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the first part of #779. The
status --strictoption causesstatusto fail if any specific package is not included in the changeset. In essence, in monorepos, currently any changeset is accepted even if it doesn't address all changed packages. This option allowsstatus --strictto be used, e.g., in CI for monorepos.Quick note for information: while I have considered using the changesets bot instead of a status CI, the issue is that our repo includes multiple packages, and most PRs affect only ignored packages or private packages where a changeset is not needed, and the bot is very verbose in those cases. A CI is quiet when it needs to be.