Skip to content

Switch to maintained fork of external-editor#1711

Closed
benmccann wants to merge 1 commit intochangesets:nextfrom
benmccann:external-editor
Closed

Switch to maintained fork of external-editor#1711
benmccann wants to merge 1 commit intochangesets:nextfrom
benmccann:external-editor

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Aug 13, 2025 •
edited
Loading

Removes tmp as a dependency which fixes the vulnerability referred to in #1710

I sent this against the next branch. It can be cherry-picked against main if we care about back-porting it or people who care about the vulnerability can switch to the 3.x branch

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025

⚠️ No Changeset found

Latest commit: 81e7246

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.05%. Comparing base (268a29f) to head (81e7246).

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1711   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          65       65           
  Lines        4998     4998           
  Branches      948      948           
=======================================
  Hits         4001     4001           
  Misses        992      992           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy
Copy link
Contributor

bluwy commented Aug 14, 2025

I think we should also backport this to v2 since v3 is still in beta. It will be easier I think if the PR merges into main, and then we can merge it up into next since it's also missing some commits from main now.

@Andarist
Copy link
Member

Andarist commented Aug 15, 2025

Agreed

@benmccann
Copy link
Contributor Author

benmccann commented Aug 15, 2025

closing in favor of #1712

@benmccann benmccann closed this Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benmccann @bluwy @Andarist