Conversation
… not being semantically treated as, respectively, `^CURRENT_VERSION` and `~CURRENT_VERSION`
🦋 Changeset detectedLatest commit: 05f4a4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 80.68% 80.71% +0.03%
==========================================
Files 54 54
Lines 2257 2261 +4
Branches 682 681 -1
==========================================
+ Hits 1821 1825 +4
Misses 431 431
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }); | ||
|
|
||
| it("should bump dependent package when bumping a `workspace:^` dependency", async () => { | ||
| it("should not bump dependent package when patch bumping a `workspace:^` dependency", async () => { |
There was a problem hiding this comment.
This test had wrong expected results. It can easily be observed by introducing this change to it:
"packages/pkg-a/package.json": JSON.stringify({
name: "pkg-a",
version: "1.0.0",
dependencies: {
- "pkg-b": "workspace:^",
+ "pkg-b": "^1.0.0",
},
}),Those should behave exactly the same as workspace:^ is just a sugar for the inlined "current version".
|
@bluwy @Andarist hi, We've tried setup new version and seems like now it's not follow docs - https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#updateinternaldependencies We have When sets Seems like now updateInternalDependencies is useless? |
|
From what I understand in the docs, the bump only happens when cutting a patch for both It would be best to open a new issue though if what you described has worked in a previous changesets version before and this PR affected it. |
|
That is right - but I agree that this option is hard to understand without examples. @reabiliti maybe you are looking for this: "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"updateInternalDependents": "always"
} |
Workaround for current issue where a release may not be triggered for a dependent package. See discussion here: changesets/changesets#1693 (comment)
4 participants
No description provided.