Skip to content

Fixed a crash in pre mode when trying to version private packages when tagging for private package is disabled#1668

Merged
Andarist merged 1 commit intomainfrom
fix/pre-version-private-disabled-tags
May 12, 2025
Merged

Fixed a crash in pre mode when trying to version private packages when tagging for private package is disabled#1668
Andarist merged 1 commit intomainfrom
fix/pre-version-private-disabled-tags

Conversation

@Andarist
Copy link
Member

fixes #1658 (a regression from #1589 )

@Andarist Andarist requested a review from bluwy May 12, 2025 11:27
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

🦋 Changeset detected

Latest commit: 39e2c4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@changesets/assemble-release-plan Patch
@changesets/cli Patch
@changesets/get-release-plan Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (5ca6271) to head (39e2c4e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files          54       54           
  Lines        2257     2257           
  Branches      682      681    -1     
=======================================
  Hits         1821     1821           
  Misses        431      431           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Andarist Andarist merged commit 65d6632 into main May 12, 2025
6 checks passed
@Andarist Andarist deleted the fix/pre-version-private-disabled-tags branch May 12, 2025 13:33
@github-actions github-actions bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unexpected error during version command in prerelease mode with private packages

2 participants