Open
Conversation
bluwy
commented
May 1, 2025
🦋 Changeset detectedLatest commit: 15cc07a The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1655 +/- ##
==========================================
+ Coverage 80.05% 80.08% +0.03%
==========================================
Files 65 65
Lines 4998 5016 +18
Branches 948 949 +1
==========================================
+ Hits 4001 4017 +16
- Misses 992 994 +2
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 17, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code added to handle the breaking change, mainly the
Packagenow needs to specifydirandrelativeDir. And thetoolneeds to be a tool from@manypkg/toolsand not just a string.There are a lot of line changes adding
package-lock.jsonto the fixtures because that's the only way for it to detect as monorepo (npm). Previously a"workspaces"only field was sufficient. @Andarist I'm not sure this is the most ergonomic, shouldn't npm monorepos be detected as fallback without the need forpackage-lock.jsonto exist?Unrelated but if I may give feedback on the new breaking APIs, I'm not a big fan of passing the
toolobject entirely from@manypkg/tools. It should've supported a simple string like before and a union of Tool object instead.Also, I'm not entirely clear for
Packagestype, why the returnedrootPackagecould be undefined whilerootDiris not?rootPackageshouldn't be possible to be undefined from what I can tell (at least for default tools).Also, I'm not sure if it was necessarily to introduce both
dir(absolute) andrelativeDir(relative) in the object. Feels redundant.