Skip to content

fix: use resolve instead of join for publishConfig.directory#1619

Merged
Andarist merged 2 commits intochangesets:mainfrom
manucorporat:patch-3
Apr 17, 2025
Merged

fix: use resolve instead of join for publishConfig.directory#1619
Andarist merged 2 commits intochangesets:mainfrom
manucorporat:patch-3

Conversation

@manucorporat
Copy link
Contributor

  • This will support better paths like: ../../dist/package

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 23b24d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (5c2bac5) to head (82e9d43).

Files with missing lines Patch % Lines
...ckages/cli/src/commands/publish/publishPackages.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1619   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          54       54           
  Lines        2241     2241           
  Branches      669      669           
=======================================
  Hits         1819     1819           
  Misses        417      417           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also need a changeset for this

@Andarist Andarist merged commit c1e8a78 into changesets:main Apr 17, 2025
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants