feat: allow nested conditions to be used in tokens #10181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
tryone144
force-pushed
the
nested-rules-for-tokens
branch
from
e7cf9c1 to
6631bb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Allow using 'nested' conditions when defining (semantic) tokens. One such example is the existing
_hovercondition that resolves tofor nesting the actual selector inside the
@media-query.⛳️ Current behavior (updates)
Using a condition that is not a simple
stringfails withTypeError: selector.startsWith is not a functionhere. This is true for the default_hovercondition here.🚀 New behavior
This PR updates the check for conditions that consist of only media-queries to support conditions that are of type
string[](like the default_hover). This then allows users to add and use their own conditions.Our project would like to overwrite the default
_darkselector to only apply on@media not printwhich requires this feature.💣 Is this a breaking change (Yes/No):
No