Repository navigation
Conversation
mheler
changed the title
mheler
changed the title
yuvalif
left a comment
yuvalif
left a comment
There was a problem hiding this comment.
we should take a different approach here.
this breaks the way the way that we do both SAL and the frontend handlers.
note that what we need to split is the librgw_lancedb not the s3vectors code.
if this is still not possible, i would take the approach that librgw_lancedb should be dynamically linked instead.
d338dd5 to
5e87576
Compare
mheler
changed the title
Thanks. I've taken the approach that |
|
looks like arm64 build is failing due to link issues: |
rgw_common put the Rust archive on every dependent binary's link line. The jammy and noble deb builds run out of memory when these links run in parallel. Build and package librgw_lancedb as a shared library, then link rgw_common against it. A link against it only reads its dynamic symbol table. Move the aarch64 lld option to the cargo link, since the C++ links no longer carry the Rust code, and have cargo link with CMake's C compiler, which passed the lld check, instead of its default cc. Keep the test binary's own provider symbols private so calls from the test environment resolve inside librgw_lancedb.so. Assisted-by: Claude Opus 5.5 Signed-off-by: Matthew N. Heler <matthew.heler@hotmail.com>
5e87576 to
68d2083
Compare
Fixes: https://tracker.ceph.com/issues/82052
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.