common/options: use an absolute libdir for osd_class_dir - #71055
Open
sunyuechi wants to merge 1 commit into
Open
common/options: use an absolute libdir for osd_class_dir#71055sunyuechi wants to merge 1 commit into
sunyuechi wants to merge 1 commit into
Conversation
osd_class_dir defaults to @CMAKE_INSTALL_LIBDIR@, which GNUInstallDirs
leaves relative ("lib64"). The OSD then looks for rados classes below
its own cwd, loads none, and every class-backed operation fails:
_load_class could not stat class lib64/rados-classes/libcls_lock.so:
(2) No such file or directory
ceph.spec.in hides this by passing an absolute -DCMAKE_INSTALL_LIBDIR.
Use @CMAKE_INSTALL_FULL_LIBDIR@ instead, as the tree already does for
other paths baked into the binaries.
Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
Config Diff Tool Output! changed: osd_class_dir: old: @CMAKE_INSTALL_LIBDIR@/rados-classes (osd.yaml.in)
! changed: osd_class_dir: new: @CMAKE_INSTALL_FULL_LIBDIR@/rados-classes (osd.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
Contributor
Author
|
/config check ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
osd_class_dirdefaults to@CMAKE_INSTALL_LIBDIR@, which GNUInstallDirsleaves relative (
lib64). The OSD then looks for rados classes below its owncwd, loads none, and every class-backed operation fails :
ceph.spec.in hides this by passing an absolute
-DCMAKE_INSTALL_LIBDIR.Use
@CMAKE_INSTALL_FULL_LIBDIR@instead, as the tree already does for otherpaths baked into the binaries.
Checklist