Skip to content

tentacle: rgw: account presigned POST bytes_received in usage log#68959

Open
lumir-sliva wants to merge 1 commit into
ceph:tentaclefrom
lumir-sliva:rgw-postobj-bytes-received-tentacle
Open

tentacle: rgw: account presigned POST bytes_received in usage log#68959
lumir-sliva wants to merge 1 commit into
ceph:tentaclefrom
lumir-sliva:rgw-postobj-bytes-received-tentacle

Conversation

@lumir-sliva
Copy link
Copy Markdown
Contributor

@lumir-sliva lumir-sliva commented May 17, 2026

Cherry-pick of 7d2484c to tentacle.

Presigned POST uploads reported bytes_received=0 in the usage log, while
equivalent PUT uploads reported the full object size.

The AccountingFilter starts disabled, and only the PUT path explicitly
enables it around its body read. POST bodies are consumed via
RGWPostObj_ObjStore::read_with_boundary, which did not toggle accounting
around its recv_body calls, so every byte pulled off the wire during
multipart parsing was silently dropped by the accounter.

Wrap the two recv_body calls in read_with_boundary with
ACCOUNTING_IO(s)->set_account(true/false), mirroring the PUT pattern in
RGWPutObj_ObjStore::get_data. POST uploads now account correctly; PUT
behavior is unchanged.

Tracker: https://tracker.ceph.com/issues/76626

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
    • Includes unit test(s)
    • Includes integration test(s)
    • Includes bug reproducer
    • No tests

@lumir-sliva
rgw: account presigned POST bytes_received in usage log
92a5044 
Presigned POST uploads reported bytes_received=0 in the usage log, while
equivalent PUT uploads reported the full object size.

The AccountingFilter starts disabled, and only the PUT path explicitly
enables it around its body read. POST bodies are consumed via
RGWPostObj_ObjStore::read_with_boundary, which did not toggle accounting
around its recv_body calls, so every byte pulled off the wire during
multipart parsing was silently dropped by the accounter.

Wrap the two recv_body calls in read_with_boundary with
ACCOUNTING_IO(s)->set_account(true/false), mirroring the PUT pattern in
RGWPutObj_ObjStore::get_data. POST uploads now account correctly; PUT
behavior is unchanged.

Signed-off-by: Lumir Sliva <61183145+lumir-sliva@users.noreply.github.com>
Tracker: https://tracker.ceph.com/issues/76157
Reported-by: Maxim Monin
(cherry picked from commit 7d2484c)
@lumir-sliva lumir-sliva requested a review from a team as a code owner May 17, 2026 09:01
@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

15 similar comments
@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@ceph-jenkins
Copy link
Copy Markdown
Collaborator

ceph-jenkins commented May 17, 2026

Thank you for your contribution. Since you, the author, are not a member of the Ceph GitHub Org yet, our CI will not automatically run. Any member of the Ceph Org may comment "ok - to - test" (without the dashes) to allow the Jenkins jobs to run.

@github-actions github-actions Bot added the rgw label May 17, 2026
@github-actions github-actions Bot added this to the tentacle milestone May 17, 2026
@github-actions github-actions Bot added the releng-audit-pass Release engineering: passed backport verification audit. label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

releng-audit-pass Release engineering: passed backport verification audit. rgw

Projects

None yet

Milestone

tentacle

Development

Successfully merging this pull request may close these issues.

2 participants

@lumir-sliva @ceph-jenkins