crimson/osd: decouple snap trim initiation from scrub completion#68948
Draft
ronen-fr wants to merge 1 commit into
Draft
crimson/osd: decouple snap trim initiation from scrub completion#68948ronen-fr wants to merge 1 commit into
ronen-fr wants to merge 1 commit into
Conversation
Add SnapTrimInitiate operation so kick_snap_trim() no longer calls on_active_actmap() inline during scrub completion, which nested conflicting with_interruption contexts and hit an assertion. Fixes: https://tracker.ceph.com/issues/76550 Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Matan-B
approved these changes
May 17, 2026
Contributor
Matan-B
left a comment
Matan-B
left a comment
There was a problem hiding this comment.
Cool catch, I think this also fixes https://tracker.ceph.com/issues/71786
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SnapTrimInitiate operation so kick_snap_trim() no longer calls on_active_actmap() inline during scrub completion, which nested conflicting with_interruption contexts and hit an assertion.
Fixes: https://tracker.ceph.com/issues/76550