Use pre-commit in workflow to check formatting
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 9, 2023 09:59
* Formatting of notebooks, using nbQA * More up to date black / isort libraries * Update `.flake8` to flake8 and black play nicely together
ryanjenkinson
force-pushed
the
update-pre-commit
branch
from
23140f8 to
ccb5435
Compare
ryanjenkinson
changed the title
pre-commit in workflow to check formatting
ryanjenkinson
force-pushed
the
update-pre-commit
branch
4 times, most recently
from
f24eeea to
bb312c7
Compare
ryanjenkinson
force-pushed
the
update-pre-commit
branch
from
bb312c7 to
695e4b0
Compare
shengy90
approved these changes
Mar 10, 2023
Contributor
shengy90
left a comment
shengy90
left a comment
There was a problem hiding this comment.
LGTM. Thanks for updating this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Functional changes:
format_check.shas the check script from the workflowpipenv run pre-commitinstead, which will always be in sync with our precommit hooks, and our local environmentStyle / docs changes:
.flake8so that black and flake8 play nicely together