Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: centrefornetzero/python-template
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: test-docker
Choose a base ref
...
head repository: centrefornetzero/python-template
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 11 files changed
  • 3 contributors

Commits on Mar 10, 2023

  1. Use pre-commit in workflow to check formatting (#10) 

    * feat: 🙈 Add `vscode` to `.gitignore`

* feat: 💄 Add better `pre-commit` hooks

* Formatting of notebooks, using nbQA
* More up to date black / isort libraries
* Update `.flake8` to flake8 and black play nicely together

* build: 👷 Use pre-commit for format checking

* refactor: ⚰️ Remove `format_check.sh` script

* docs: 📝 Update README with setup instructions

* style: 💄 Make sure `.flake8` has newline

* build: 👷 Ensure `container.yaml` uses `pre-commit` to check formatting

* Add show-diff-on-failure to containers.yaml

* Test commit to show pre-commit hooks failing

* Get workflows to pass

* style: 🚚 `test_and_lint` -> `lint_and_test`

* style: 🚚 Change workflow name to Lint and test
    @ryanjenkinson
    ryanjenkinson authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d9106d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Add DS_Store to gitignore (#12)

    @ryanjenkinson
    ryanjenkinson authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    cda811f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Remove --keep-outdated flag in pipenv sync (#14) 

    * Remove --keep-outdated flag in pipenv sync

This is flagging error in docker builds. delete this.

* Add mypy to list of precommit checks

So that we can close the old PR:
https://github.com/centrefornetzero/python-template/pull/13/files

* Remove --keep-outdated
    @shengy90
    shengy90 authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    252672b View commit details
    Browse the repository at this point in the history

  2. Python 3 11 upgrade (#15) 

    * Update python dependencies from 3.9 to 3.11

* Update python dependencies from 3.9 to 3.11

* run pre-commit on all files locally

* update pipfile.lock to be compatible with py3.11
    @charlotte-avery
    charlotte-avery authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    e8c6cf3 View commit details
    Browse the repository at this point in the history
Loading