Repository navigation
Enable scoped analyzers for vector AST helpers - #4
Open
allancascante wants to merge 2 commits into
Open
allancascante wants to merge 2 commits into
allancascante wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable Microsoft.CodeAnalysis.NetAnalyzers for the ScriptDOM project and scope analyzer warnings to the hand-written vector support files. This addresses HU-03 maintainability findings while avoiding analyzer warnings in unrelated source files.
The cleanup documents the public vector enum members, narrows helper singleton visibility, and removes an unused import. No parser behavior, AST declarations, or baselines were changed.
Validation:
dotnet build SqlScriptDom/Microsoft.SqlServer.TransactSql.ScriptDom.csproj --no-restore -f net8.0 -p:NoWarn=SYSLIB0051— passed with 0 warnings and 0 errors. The suppression excludes existingSYSLIB0051warnings outside this change’s scope.dotnet test Test/SqlDom/UTSqlScriptDom.csproj --no-restore -f net8.0 --filter "FullyQualifiedName~TSql170SyntaxIn170ParserTest"— passed; 1 test passed, covering the existing TSql170 baselines.Code Changes