Repository navigation
Validate VECTOR_DISTANCE dimensions in TSql170 - #2
Open
allancascante wants to merge 1 commit into
Open
allancascante wants to merge 1 commit into
allancascante wants to merge 1 commit into
Conversation
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VECTOR_DISTANCEargument.46146when an integer dimension is outside the valid range of 1 through 1984.Implementation
Sql170ExpressionVisitorto inspectVECTOR_DISTANCEfunction calls.int.TryParseand C# pattern matching.TSql170Parserafter parsing.Vector dimension must be an integer between 1 and 1984.TDD Evidence
1/1aterrors.Count > 0because the parser returned no errors.1/1.Testing
Passed:
dotnet test Test/SqlDom/UTSqlScriptDom.csproj -c Debug -f net8.0 --filter "FullyQualifiedName~TestVectorDistance_InvalidDimension_ShouldReturnParseError"
The full net8.0 suite was started but canceled after test discovery. No test failure was reported before cancellation.
Code Changes