Metacask reported the following issue and I've repro'd it.

The Signer returns an error if a request is made to sign a message whilst it's locked. It should instead prompt to unlock and then proceed with the signing process as expected.