Open
Conversation
ajnelson-nist
requested changes
Aug 4, 2020
Member
ajnelson-nist
left a comment
There was a problem hiding this comment.
NACK, the patch series is not yet ready for merge. The README statement added is not substantiated by the state of the code.
- There is no designation of the versions of CASE or UCO supported. I recommend a Git submodule pointing to CASE at the prototype release commit (3718ddf), with the submodule housed at
/dependencies/CASE. - There is no
__version__variable in any file under the/srcdirectory.
This stumbles into a support level we hadn't documented in our policy page, but looks to me like a "Pre-alpha" status because the code doesn't do the above two items.
This PR doesn't pass my review unless it sets development status to pre-alpha, or the code is modified to satisfy the alpha status requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.