Skip to content

Additional parts for exporting local_uuid - #144

Merged
kchason merged 6 commits into
developfrom
export_local_uuid
Jan 10, 2024
Merged

Additional parts for exporting local_uuid#144
kchason merged 6 commits into
developfrom
export_local_uuid

Conversation

@ajnelson-nist

Copy link
Copy Markdown
Member

This is a follow-on to #140 .

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Before this patch, the `pytest` calls in unit testing raise the
`DeprecationWarning` from `case_utils.local_uuid`.  E.g. both of these
test files would raise the warning:

(test1.py)

```python
def test_foo() -> None:
    import case_utils
```

```bash
pytest test1.py
# Logs deprecation warning.
```

(test2.py)

```python
import case_utils
def test_foo() -> None:
    pass
```

```bash
pytest test2.py
# Logs deprecation warning.
```

This patch removes the module re-export.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the 0.15.0 milestone Dec 13, 2023
@ajnelson-nist

Copy link
Copy Markdown
Member Author

I've realized there's an update that should happen for cdo-local-uuid. At least one more patch coming before this PR's ready.

@ajnelson-nist ajnelson-nist mentioned this pull request Dec 19, 2023
@ajnelson-nist
ajnelson-nist marked this pull request as ready for review January 9, 2024 21:49
@ajnelson-nist
ajnelson-nist requested a review from a team as a code owner January 9, 2024 21:49
@kchason
kchason merged commit 91bae5e into develop Jan 10, 2024
@kchason
kchason deleted the export_local_uuid branch January 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants