homework: more tests

carokanns · carokanns · commit 3d292d3ef91f · 2018-03-08T21:17:40.000+01:00
diff --git a/bitboard_test.go b/bitboard_test.go
@@ -1,3 +1,4 @@
+
 package main
 
 import (
diff --git a/castlings_test.go b/castlings_test.go
@@ -1,4 +1,3 @@
-
 package main
 
 import (
@@ -85,7 +84,7 @@ func Test_parseCastlings(t *testing.T) {
 		{"", "kq", castlings(shortB | longB)},
 		{"", "Kk", castlings(shortW | shortB)},
 		{"", "KQkqrr", castlings(shortW | longW | shortB | longB)},
-		{"", "kQq", castlings( longW | shortB | longB)},
+		{"", "kQq", castlings(longW | shortB | longB)},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -95,3 +94,25 @@ func Test_parseCastlings(t *testing.T) {
 		})
 	}
 }
+
+func Test_castlings_String(t *testing.T) {
+	tests := []struct {
+		name string
+		c    castlings
+		want string
+	}{
+		{"", 0, "-"},
+		{"", castlings(shortW | longB), "Kq"},
+		{"", castlings(shortW | longB), "Kq"},
+		{"", castlings(shortW | longW), "KQ"},
+		{"", castlings(shortB | longB), "kq"},
+		{"", castlings(shortW | longB | shortB | longW), "KQkq"},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := tt.c.String(); got != tt.want {
+				t.Errorf("castlings.String() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
diff --git a/main.go b/main.go
@@ -7,5 +7,3 @@ func main() {
 
 	tell("info string quits GOBIT")
 }
-
-// TODO: A credential helper: https://help.github.com/articles/caching-your-github-password-in-git/ 
diff --git a/move.go b/move.go
@@ -12,15 +12,15 @@ const (
 	SE = -NW
 )
 
-var pieceRules[nP][]int // not pawns
+var pieceRules [nP][]int // not pawns
 type moveList struct {
 	mv []move
 }
-func init(){
-	pieceRules[Rook] = append(pieceRules[Rook],E)
-	pieceRules[Rook] = append(pieceRules[Rook],W)
-	pieceRules[Rook] = append(pieceRules[Rook],N)
-	pieceRules[Rook] = append(pieceRules[Rook],S)
+func init() {
+	pieceRules[Rook] = append(pieceRules[Rook], E)
+	pieceRules[Rook] = append(pieceRules[Rook], W)
+	pieceRules[Rook] = append(pieceRules[Rook], N)
+	pieceRules[Rook] = append(pieceRules[Rook], S)
 }
 
 func (ml *moveList) add(mv move) {
diff --git a/move_test.go b/move_test.go
@@ -0,0 +1,32 @@
+package main
+
+import "testing"
+
+func Test_moveList_add(t *testing.T) {
+	tests := []struct {
+		name string
+		ml   moveList
+		mv move
+	}{
+		{"", moveList{},0},
+		{"", moveList{},1},
+		{"", moveList{},2},
+		{"", moveList{},3},
+	}
+
+	ml = moveList{}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			tt.ml = tt.ml
+			tt.ml.add(tt.mv)
+			ix:=len(tt.ml.mv)-1
+			if ix<0{
+				t.Fatalf("wrong len %v: %v %v %v",ix,tt.ml,tt.ml.mv,tt.ml.mv[0])
+			}
+			testMv := tt.ml.mv[ix]
+			if  testMv != tt.mv{
+				t.Errorf("tt.ml.add() = %v. want %v",testMv,tt.mv)
+			}
+		})
+	}
+}
diff --git a/uci.go b/uci.go
@@ -184,6 +184,8 @@ func handleGo(words []string) {
 			tell("info string go mate not implemented")
 		case "infinite":
 			tell("info string go infinite not implemented")
+		case "register":
+			tell("info string go register not implemented")
 		default:
 			tell("info string go ", words[1], " not implemented")
 		}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+`
`1`	`2`	`package main`
`2`	`3`
`3`	`4`	`import (`
Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,3 @@ func main() {`
`7`	`7`
`8`	`8`	`tell("info string quits GOBIT")`
`9`	`9`	`}`
`10`		`-`
`11`		`-// TODO: A credential helper: https://help.github.com/articles/caching-your-github-password-in-git/`
Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,8 @@ func handleGo(words []string) {`
`184`	`184`	`tell("info string go mate not implemented")`
`185`	`185`	`case "infinite":`
`186`	`186`	`tell("info string go infinite not implemented")`
	`187`	`+ case "register":`
	`188`	`+ tell("info string go register not implemented")`
`187`	`189`	`default:`
`188`	`190`	`tell("info string go ", words[1], " not implemented")`
`189`	`191`	`}`